Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate SystemVerilog parameter syntax when there are 0 parameters #498

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

This is a bug fix for when parameter arguments in custom-generated SystemVerilog have provided parameter information (either instantiation or definition), but the list/map is empty (but non-null). It is illegal SystemVerilog syntax to generate something like #( ), but that's what was being generated. The fix is to look for null OR empty conditions.

Related Issue(s)

N/A

Testing

Added a new test that covers both instantiation and definition empty parameter scenarios.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit d29d920 into intel:main Jul 30, 2024
3 checks passed
@mkorbel1 mkorbel1 deleted the empty_params branch July 30, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant